Colour scheme is now consistent within MSlice #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the colour name directly in set_option now the name_to_color function from mslice.models.colors is used. This ensures that a colour name is always mapped to the same hex value. The hex mapping for basic colours has been updated as well to reflect the colour scheme changes within matplotlib. The hex values are now hardcoded instead of generated dynamically on start up to speed up plotting. It is still possible to use colours that are not included in the basic colour mapping though.
To test:
Create a cut plot with several lines and change a line setting, for instance 'Show Legends'. After clicking on Ok the colours of the lines should not change.
Also, try to re-test #550 as this should still be fixed.
Fixes #733