Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags for selecting rustls or openssl as the tls implementation. #105

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

AlterionX
Copy link
Contributor

@AlterionX AlterionX commented Sep 20, 2021

A simple switch for allowing reqwest to compile with rustls instead of native which relies on openssl.

openssl is known to be a non-trivial dependency in the compilation process.

@AlterionX
Copy link
Contributor Author

I may need some instructions about how to test the change.

Running cargo test seems to fail by default, even on the current master.

algonaut_client/Cargo.toml Show resolved Hide resolved
src/algod/mod.rs Show resolved Hide resolved
@ivnsch
Copy link
Contributor

ivnsch commented Sep 23, 2021

Thanks for you contribution! To understand better/for the record: why do we want to keep the possibility to use native? From a quick search it seems to be possibly quicker updates via the OS libraries and smaller binaries (dynamic linking), is this correct?

@ivnsch
Copy link
Contributor

ivnsch commented Sep 23, 2021

I may need some instructions about how to test the change.

Running cargo test seems to fail by default, even on the current master.

The tests are WIP (#1, #62). Those failing tests are integration tests that depend on a running local network and indexer. The CI currently executes this (which excludes them):

cargo test --workspace --lib --examples --test test_account --test test_logic_signature

@AlterionX
Copy link
Contributor Author

AlterionX commented Oct 14, 2021

Oops, I've been a bit busy with work and forgot to check back on this.

About retaining the ability to use native: yes, that's basically it. The actual implementation should be abstracted away cleanly by lower level libs anyways, and not be a maintenance burden.

@ivnsch ivnsch merged commit b727728 into manuelmauro:main Oct 18, 2021
@AlterionX AlterionX deleted the rustls-feature branch February 1, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants