Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appdata: Improve appdata for AppStream 1.0 #628

Merged
merged 2 commits into from Jan 2, 2024
Merged

appdata: Improve appdata for AppStream 1.0 #628

merged 2 commits into from Jan 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 28, 2023

appdata: Improve appdata for AppStream 1.0

  • Add the <developer><name> tag
  • Mark the <developer_name> tag as deprecated
  • Improve appstreamcli arguments

appdata: Fix my mistake

"Icons and categories

If there’s a type="desktop-id" launchable, they get pulled from it.
Most of the icon not found errors with the flathub builder can be
traced down to the launchable value not matching the desktop file name.

Don’t set them in the AppData unless you want to override them
(even though then it might be a better idea to patch the desktop file
itself)."

More information: https://docs.flathub.org/docs/for-app-authors/appdata-guidelines/#icons-and-categories

Sabri Ünal added 2 commits December 28, 2023 22:58
"Icons and categories

If there’s a type="desktop-id" launchable, they get pulled from it.
Most of the icon not found errors with the flathub builder can be
traced down to the launchable value not matching the desktop file name.

Don’t set them in the AppData unless you want to override them
(even though then it might be a better idea to patch the desktop file
itself)."

More information: https://docs.flathub.org/docs/for-app-authors/appdata-guidelines/#icons-and-categories
- Add the `<developer><name>` tag
- Mark the `<developer_name>` tag as deprecated
- Improve appstreamcli arguments
@ghost ghost changed the title Fix appdata appdata: Improve appdata for AppStream 1.0 Dec 29, 2023
@maoschanz maoschanz added enhancement ideas to improve existing features packaging problems or question about the creation/maintenance of packages labels Jan 2, 2024
@maoschanz
Copy link
Owner

unless you want to override them (even though then it might be a better idea to patch the desktop file itself)

last time i tried, i couldn't find a way to tell gettext how to translate the keywords as cleanly as with the XML

the desktop file has this awful Keywords=word1;word2;word3; thing where i have to write a very long comment to tell translators what to do with for each word, and to be sure to include the semicolons, etc.

in an ideal situation, the desktop file would get generated from the more precise appdata, rather than the opposite: do you know if it's currently possible?

@maoschanz maoschanz merged commit 9e2cc6c into maoschanz:master Jan 2, 2024
2 checks passed
@ghost
Copy link
Author

ghost commented Jan 2, 2024

I extracted the latest drawing appdata from the recent appstream file, and the keywords seem okay to me here.

Gettext uses translated keywords to add to the XML file rather than translating them one by one.

@maoschanz
Copy link
Owner

seem okay to me here

yes because i actively review each translation before merging them, to ensure every language always has "Paint" as an untranslated keyword, and semicolons after each keyword in this string, so it's parsed correctly and the appdata are complete in every language. But it's kinda tedious to do...

But if it's not something meson or appstream-util or gettext can do from the .in files, then ok i can keep doing like i was doing until now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ideas to improve existing features packaging problems or question about the creation/maintenance of packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant