Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #92 - Generate exact single tile #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

montzkie18
Copy link

Exposing new method geoJSONToTile to generate a specific VT based on passed z/x/y values.

This should skip generating parent tiles on all higher zoom levels for the requested tile.

This ports the C++ functionality implemented by @asheemmamoowala in mapbox/geojson-vt-cpp#65

package.json Outdated Show resolved Hide resolved
@jayarjo
Copy link

jayarjo commented May 14, 2021

Please merge this.

@montzkie18
Copy link
Author

hi @mourner - any chance I can get a review on this one? thanks!

@mourner
Copy link
Member

mourner commented May 24, 2021

Sorry for the late response. I'll need to consider this change more thoroughly because this is technically breaking for the UMD bundle — when you have both default and named exports, the bundle will expose geojsonvt as geojsonvt.default.

@kevincennis
Copy link

@mourner would you be open to a version of this that just tacks something like singleTileFromGeoJSON() on to the exported geojsonvt function?

i.e. geojsonvt.singleTileFromGeoJSON = function() { /* do things */ }

That's maybe a little weird, but it sidesteps the export issue at least

@kikonejacob
Copy link

@mourner @montzkie18 Any update on this?
It will be nice if this can be merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants