This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Distinguish between internal and external Carthage usage #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new Cartfile.private lists the dependencies necessary to build the map SDK from source, while the main Cartfile now obtains the prebuilt map SDK itself. A developer can now point their Cartfile to this repository to install the map SDK. A contributor would get both sets of dependencies when bootstrapping but can ignore the prebuilt SDK binary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new Cartfile.private lists the dependencies necessary to build the map SDK from source, while the main Cartfile now obtains the prebuilt map SDK itself along with MapboxMobileEvents. A contributor will get both sets of dependencies when bootstrapping, but they can ignore the prebuilt SDK binary. Meanwhile, a developer can now point their Cartfile to this repository to install the map SDK (after setting up the .netrc file):
github "mapbox/mapbox-gl-native-ios" ~> 6.3When releasing the map SDK, the version specification in Cartfile needs to be updated to exactly match the version being tagged – prereleases and final releases alike.
With this change, developers no longer need to keep track of compatible MapboxMobileEvents versions themselves, giving us some room to increase the minimum supported MME version when necessary. Unfortunately, developers will end up with a full clone of this repository. Deleting old tags carried over from the mapbox-gl-native repository would help a bit: #109. If cloning this repository makes the
githubspecification impractical, or if the intention all along was to allow external developers to build gl-native-ios from source using Carthage, then we should close this PR and copy the Cartfile to a separate repository that hosts only the Cartfile.Wherever we put the Cartfile, we can expect the Package.swift for Swift Package Manager (mapbox/mapbox-gl-native#15241 #546) to sit alongside it.
Fixes #143.
/ref #326
/cc @mapbox/maps-ios @mapbox/navigation-ios @frederoni