Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Detect big buildings #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Detect big buildings #45

wants to merge 1 commit into from

Conversation

Rub21
Copy link
Contributor

@Rub21 Rub21 commented Dec 7, 2016

cc. @bkowshik

@batpad
Copy link
Contributor

batpad commented Feb 8, 2017

@bkowshik @amishas157 - can we take a look at this tomorrow - the compare function looks generally good. I'll take a look at why tests are failing as well.

@batpad
Copy link
Contributor

batpad commented Feb 10, 2017

hey @Rub21 I tried rebasing this on master and re-running the tests, and your test for the big_buildings function is still failing.

Could you check your fixtures at: https://github.com/mapbox/osm-compare/blob/rub21/tests/fixtures/big_buildings.json

It seems like the last fixture has an expectedResult of true, but the comparator is returning an empty object.

Let me know if I can help - this looks good to me if we can fix tests and rebase against master.

@amishas157
Copy link
Contributor

Hi @Rub21 @batpad
Now we have a large building compare function , not sure if this is different from that one. If not, should be close this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants