Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wip #69

wants to merge 1 commit into from

Conversation

chriswhong
Copy link
Contributor

@chriswhong chriswhong commented Nov 18, 2024

This PR includes several updates to the storytelling template.

  • mapboxgl is updated to 3.8.0
  • intersection-observer is no longer required as a dependency
  • index.html and config.js are moved to the root of the repo, allowing index.html to be run from the live-server extension in V.S. Code without difficulty.
  • The inset map implementation was creating a second Mapbox GL JS instance, which would incur additional map loads. It has been removed and replace with the mapbox-gl-globe-minimap plugin, which renders an SVG minimap. Additional configuration for the globe minimap is added.
  • README is updated to include tables for all configuration options for easier readability.
  • Additional instructions have been added for how to run the storytelling app using the live-server extension in Visual Studio Code.

Updates are made to the default config.js file to get rid of placeholder text:

  • The chapters are all titled with the cities they show, and images from wikimedia commons have been added to each chapter.
  • The user only needs to add their access token and can explore the fully-functional storytelling map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant