-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix renderWorldCopies regression #5027
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5027 +/- ##
==========================================
+ Coverage 89.25% 89.29% +0.03%
==========================================
Files 269 269
Lines 38286 38293 +7
Branches 2347 2337 -10
==========================================
+ Hits 34172 34192 +20
+ Misses 3117 3110 -7
+ Partials 997 991 -6 ☔ View full report in Codecov by Sentry. |
Thanks @NathanMOlson - I tried it applying this change manually, but I still see some issues with clamping. |
Please add the relevant tests so this won't break in the future... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to run it. It does appear to work like I'd expect it to
Tests are needed for reported bugs.
This fixes #5024.