Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renderWorldCopies regression #5027

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NathanMOlson
Copy link
Contributor

@NathanMOlson NathanMOlson commented Nov 9, 2024

This fixes #5024.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.

@NathanMOlson NathanMOlson marked this pull request as draft November 9, 2024 16:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (8555091) to head (cde15ad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5027      +/-   ##
==========================================
+ Coverage   89.25%   89.29%   +0.03%     
==========================================
  Files         269      269              
  Lines       38286    38293       +7     
  Branches     2347     2337      -10     
==========================================
+ Hits        34172    34192      +20     
+ Misses       3117     3110       -7     
+ Partials      997      991       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@birkskyum
Copy link
Member

birkskyum commented Nov 9, 2024

Thanks @NathanMOlson - I tried it applying this change manually, but I still see some issues with clamping.

@NathanMOlson NathanMOlson marked this pull request as ready for review November 9, 2024 22:16
@HarelM
Copy link
Collaborator

HarelM commented Nov 9, 2024

Please add the relevant tests so this won't break in the future...

birkskyum
birkskyum previously approved these changes Nov 9, 2024
Copy link
Member

@birkskyum birkskyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to run it. It does appear to work like I'd expect it to

@HarelM HarelM dismissed birkskyum’s stale review November 9, 2024 22:29

Tests are needed for reported bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants