Update desktop build to pull from this repo

[kevinschaul]

Previously the desktop build lived in a separate repo and had to download a released version of the maputnik editor source code. Now that both live in the same repo, the desktop version can simply run the maputnik build command and use those generated files.

This commit also removes the ci-desktop workflow, which is not needed. The regular ci workflow already built the desktop version (this commit also fixes that build).

Fixes #919

If this works for you all, it would be lovely to create a new tag or release on GitHub for two reasons:

1. So the latest binaries are easier to locate, and
2. So I can update my submission to homebrew to make installation easier (for os x users at least)

[HarelM]

Thanks!!
Any change you can take a look if there are some CI github actions that nees to be updated? I see the following warnings:

Have you tested the attached binaries to see that they work as expected?

In regard to tagging, I don't have strong objections, but now it's extremely nice that everything is pushed right to production without extra steps - proper CI/CD style.

How did you plan to decide which tag to put?

In maplibre-gl-js I added a version change check to the npm version and every commit that changes the version and pushed to main will create a tag and a new release.
I've done so in other maplibre libraries as well, see below.
This updates some part of the changelog and opens a PR to bump the version:
https://github.com/maplibre/maplibre-gl-js/blob/bc70bc559cea5c987fa1b79fd44766cef68bbe28/.github/workflows/create-bumb-version-pr.yml
This one will check for a version change and take care of the rest:
https://github.com/maplibre/maplibre-gl-js/blob/bc70bc559cea5c987fa1b79fd44766cef68bbe28/.github/workflows/release.yml

Generally speaking, I'm good with what you decide as long as it doesn't create maintenance overhead (especially the changelog part which is still not automatic for maplibre-gl-js and it probably can be).

Also, it would be great to add a docker image too that is published to ghcr.

[kevinschaul]

Thank you! I've corrected two of those warnings. The others are related to codecov/codecov-action@v3, which looks potentially tricky to update.

I have tested the darwin and linux binaries. Unfortunately I don't have a Windows machine to test that version.

Re: tags/releases, you raise good questions that I'm not sure I'm qualified to answer 🥲. I like what you have done in maplibre-gl-js. It makes sense to me to follow that pattern. Do you want me to try implementing that for this repo?

[HarelM]

Sure, it would be great to have an auto generated changelog as opposed to maplibre-gl.
But if that's too complicated then let's keep it for later.
I think we can continue to publish the latest version to docker and the website (github pages) and only publish a desktop version when the version changes.
What do you think?

[kevinschaul]

If you're ok with us doing a manual desktop publish every once in a while, that seems good to me.

[kevinschaul]

One last idea I'll throw out there. We could switch to dated version numbers. Any push to main would updated the version number to the current date. And any push to main would push a release. That way it's all automated and the latest desktop version will always match the version hosted at maplibre.org.

I'm happy with whatever, though!

[HarelM]

The date is a nice idea but then you'd need to either commit to main after every commit, not have the version in the package.json or have a non semver version.
Considering the above, manual release of desktop is the lesser evil.
Let me know if you need any help understanding the above gihub yaml files.

[kevinschaul]

Got it. I should have these working tomorrow.

[kevinschaul]

OK @HarelM these workflows are in. I'm not sure how to test besides by trying to make a release. Let me know how you want to proceed! And thanks for all your help.

[HarelM]

Let's try it out.
2.1.0 version?

[HarelM]

See here:
https://github.com/maplibre/maputnik/actions/runs/10616707881/job/29427776714
Probably chmod issue...

[HarelM]

Here's the run results,
Seemed to fail on the release note script:
https://github.com/maplibre/maputnik/actions/runs/10619718712/job/29437920164

Also isn't not clear why we are building both web and desktop and only using the desktop output...?

[kevinschaul]

Fixed that in #926.

The web output ends up as an artifact as well, called dist.zip. Happy to remove if you prefer this to only publish the desktop.zip artifact.

[HarelM]

We can publish to npm if someone is interested later on, I don't see a real benefit to it as is.
Feel free to remove, although not a critical issue.

[kevinschaul]

OK yep makes sense, I'll remove