Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation process and small fixes #930

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Add translation process and small fixes #930

merged 5 commits into from
Sep 2, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Sep 1, 2024

Launch Checklist

This adds information about how to translate Maputnik and how to get in touch with people who have translated in the past.
@keichan34, @jieme, @lhapaipai - I need your approval for this so that people in the future will know to contact you in case text is being added and they need help translating it.

CC: @ianthetechie

I've also changed the word "Language" in the upper part of the screen so that it won't be translated in case you accidentally switch language, and you need to switch back.

I've also fixed some RTL issues in the CSS and updated the maplibre components labels when the language changes.

@lhapaipai
Copy link
Contributor

It's ok for me.

@HarelM HarelM changed the title Add translation process Add translation process and small fixes Sep 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.60%. Comparing base (4dd34e9) to head (64e426b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/MapMaplibreGl.tsx 71.42% 2 Missing ⚠️
src/libs/zoomcontrol.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   58.70%   58.60%   -0.11%     
==========================================
  Files         104      104              
  Lines        3020     3027       +7     
  Branches      669      669              
==========================================
+ Hits         1773     1774       +1     
- Misses       1247     1253       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating locales/README.md!

src/components/MapMaplibreGl.tsx Show resolved Hide resolved
@ianthetechie
Copy link
Contributor

Thanks for the mention @HarelM! I can strike the less complete localization guide from my work in progress PR now :)

@HarelM
Copy link
Collaborator Author

HarelM commented Sep 2, 2024

Let's have this deployed, other issues can be fixed later on.

@HarelM HarelM merged commit 60785f5 into main Sep 2, 2024
7 checks passed
@HarelM HarelM deleted the translation-process branch September 2, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants