add german translation, update docs #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
josxha
commented
Sep 2, 2024
josxha
commented
- add german translation (following the changes in Add french language support #929)
- using an alphabecial order for the languages
- update the documentation with a step-by-step guide
- add myself as a helping person for german
- move the helping-users list to the implementation of new features
- update CHANGELOG.md
- add a link to the l18n README in the root README
- add instructions to follow along more easily - use code generation for new locales - addad myself as helping user for the german language - sort languages alphabetically
HarelM
reviewed
Sep 2, 2024
README.md
Outdated
| @@ -72,6 +72,10 @@ npm run lint-css | |||
| npm run sort-styles | |||
| ``` | |||
|
|
|||
| ### Translations & Localization | |||
|
|
|||
| See [/src/locales/README.md](/src/locales/README.md) | |||
There was a problem hiding this comment.
This exists a few paragraphs up.
There was a problem hiding this comment.
Woops, missed that. I reverted the file.
|
Thanks!! |
HarelM
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.