-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same version number for web and desktop #932
Conversation
With the new release process in place, I think keeping a separate version number for desktop is confusing and unnecessary. This PR remove it so the desktop version reports the version number of the web version embedded in the binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds right to me.
I know that in windows you can check excitable file properties and see a version number. Is this number shown there? |
@HarelM that's a good question. I do not think the version number would be included there currently. A quick search reveals a few tools to embed that information, e.g. https://github.com/tc-hib/go-winres. But unfortunately I do not have access to a Windows machine, so I would be unable to test this. |
I can check if you upload it, if that helps. |
@HarelM Can you check this artifact on Windows? https://github.com/maplibre/maputnik/actions/runs/10707430874?pr=932 |
Looks good! the only comment I have is regarding the icon (top left corner in the following screenshot), would be nice if it had the Maputnik icon for it instead of the default windows exe icon. |
This may have done it. https://github.com/maplibre/maputnik/actions/runs/10707828481?pr=932 |
Interesting, I think I'll leave the icon as-is. Good nice-to-have for the future, though. And agreed that it should open the browser. I'll add that as a new issue and hopefully get to it soon! Thank you! |
With the new release process in place, I think keeping a separate version number for desktop is confusing and unnecessary. This PR remove it so the desktop version reports the version number of the web version embedded in the binary.
Launch Checklist
CHANGELOG.md
under the## main
section.