Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Americana and Protomaps Light styles #936

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Sep 15, 2024

We have been added to the CORS (Cross-Origin Resource Sharing) allowlist, so we can use Americana on maplibre.org.

https://tile.ourmap.us/usage.html

This style is FOSS so it will be an especially great addition to the Maputnik default styles.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@louwers
Copy link
Collaborator Author

louwers commented Sep 16, 2024

I don't have write permissions for this repo, so you'll have to merge it @HarelM 🙂

@nyurik
Copy link
Member

nyurik commented Sep 16, 2024

I just added you with write

@louwers
Copy link
Collaborator Author

louwers commented Sep 16, 2024

I also added Protomaps Light to make everything nice and symmetric again.

The API key is linked to [email protected] and only has maplibre.org in the CORS allowlist.

image

@louwers louwers changed the title Add Americana style Add Americana and Protomaps Lights styles Sep 16, 2024
@louwers
Copy link
Collaborator Author

louwers commented Sep 16, 2024

Thanks @nyurik

@louwers louwers requested a review from HarelM September 16, 2024 23:04
@louwers louwers requested a review from nyurik September 16, 2024 23:06
@louwers louwers changed the title Add Americana and Protomaps Lights styles Add Americana and Protomaps Light styles Sep 16, 2024
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.40%. Comparing base (4dd34e9) to head (e2c1616).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   58.70%   58.40%   -0.31%     
==========================================
  Files         104      104              
  Lines        3020     3027       +7     
  Branches      669      669              
==========================================
- Hits         1773     1768       -5     
- Misses       1247     1259      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louwers louwers merged commit fa4ece2 into maplibre:main Sep 16, 2024
7 checks passed
@louwers louwers deleted the americana branch September 16, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants