-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PMTiles support #938
base: main
Are you sure you want to change the base?
Add PMTiles support #938
Conversation
Thanks for taking the time to open this PR. |
I saw your comment there, but comparing PMTiles with MBTiles didn't make sense for me. PMTiles can be used as local and remote datasource like mvt files when using an HTTP server with Range Request support. |
But you still need a http server with range support... From my point if view using a tile server or worker is not a big lift. |
There are not many HTTP servers without Range Request support ( Switching the tile source in a style created with Maputnik is a one-liner like |
I could argue that you won't need to run the above script at all and using Martin or tileserver-gl (using docker, or even without) is not that complicated... |
@pka It might be helpful if you could write your full use-case in #807. Where is the pmtiles file you want to reference? Is it on your local machine or hosted somewhere? For background I also use maputnik + PMTiles but with a separate tool that runs both. If we can all share our use-cases, that could help reveal pain points and potential solutions. |
@nyurik @lseelenbinder Could you maybe help formulating use cases for styling maps with PMTiles storage? |
* add PMTiles mode to source editing dialog * App.tsx detects PMTiles sources for fetching vector_layers (inspect does not yet work)
here is the necessary changes to add PMTiles for vector sources to the UI: This works fine with remote sources e.g. you can paste in However, the "inspect" panel doesn't work yet because it relies on MapLibre internals to fetch TileJSON. The inspect panel will work once protomaps/PMTiles#247 is implemented. (EDIT: I implemented 247 above, so inspect works now.) |
d9c69f3
to
69c2a5b
Compare
69c2a5b
to
34da461
Compare
a11dc3e
to
d3d4c99
Compare
There is a UI issue right now where the |
Add support for pmtiles sources. Solves #807
There is still an error, probably when adding the source to the Maputnik sources:
@bdon How did you solve this for https://editor.protomaps.com/ ?