Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheme type options for vector/raster tile #943

Merged
merged 5 commits into from
Sep 29, 2024
Merged

Conversation

huanglii
Copy link
Contributor

@huanglii huanglii commented Sep 25, 2024

Launch Checklist

  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

image

@HarelM
Copy link
Collaborator

HarelM commented Sep 25, 2024

Can you create a "before" and "after" screenshots?

@huanglii
Copy link
Contributor Author

Before After
Vector tile image image
Raster tile image image

@HarelM
Copy link
Collaborator

HarelM commented Sep 26, 2024

Thanks!
Can you please add a test that adds a source, changes the scheme and makes sure this is updated in the style? (i.e. e2e test)

Otherwise, this looks great, thanks!
There is a comment above one of the places you changed that needs an update I believe (something with a hack, that might not be true any more).

@HarelM HarelM merged commit 6089cde into maplibre:main Sep 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants