Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print statement in astar.py #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MalloryWittwer
Copy link

Hi! I think it would be good to remove the print statement "Found goal!" in astar.py. In certain applications where the algorithm runs in a loop, the message gets printed continuously, which makes debugging difficult. Thank you!

@cudmore
Copy link
Member

cudmore commented Feb 7, 2024

Thanks for the feedback. We removed the Found Goal! by default but it can be optionally turned back on. Our search function now looks like this

    def search(self, verbose : bool = False) -> List[np.ndarray]:
        """Performs A star search to find the brightest path

        Parameters
        ----------
        verbose (bool)
            If True, will print `Found goal!` when goal is found.

        Returns
        -------
        List[np.ndarray]
            the list containing the 2D/3D point coordinates
            that constitute the brightest path between the
            start_point and the goal_point

@MalloryWittwer
Copy link
Author

That's awesome! Thank you for making these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants