adding CDL mappings #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding mappings for phenotypes from MP and HPO associated with Cornelia de Lange syndrome models and patients, respectively
|
This is a great effort @sbello! I would suggest at the next MP-HP call, I will come and we can talk about the for and against being that fine grained in terms of mapping predicates. You are definitely on the "white", "Jedi" side of things, but you leave some opportunities on the table for analytics - Its good to just be aware of it, and document it. |
|
@matentzn sounds good, I'll add it to the agenda |
|
Can you ping me on the day of the call to remind me to hop on? <3 |
1 similar comment
|
Can you ping me on the day of the call to remind me to hop on? <3 |
|
Will do, it is this Thursday (8/3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding mappings for phenotypes from MP and HPO associated with Cornelia de Lange syndrome models and patients, respectively