Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Metadata usages #447

Merged
merged 29 commits into from
Oct 12, 2023
Merged

Cleanup Metadata usages #447

merged 29 commits into from
Oct 12, 2023
+74 −91

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Oct 5, 2023 •
edited
Loading

  • Standardizes additional handling of prefix maps and metadata
  • Deletes the no longer used Metadata class
  • Deletes sssom.typehints module (which was not named aptly for how it was used) and moves its remaining functionality into sssom.constants

@cthoyt cthoyt marked this pull request as ready for review October 6, 2023 08:07
@cthoyt cthoyt requested a review from matentzn October 6, 2023 09:13
@cthoyt cthoyt removed the request for review from matentzn October 7, 2023 10:24
@cthoyt cthoyt marked this pull request as draft October 7, 2023 10:24
@cthoyt cthoyt changed the title Cleanup Metadata usages [EPIC] Cleanup Metadata usages Oct 7, 2023
@cthoyt cthoyt force-pushed the update-metadata-merging branch from b603218 to 6ad0ee2 Compare October 9, 2023 13:45
@cthoyt cthoyt force-pushed the update-metadata-merging branch from bce27f8 to 296b486 Compare October 9, 2023 13:50
@cthoyt cthoyt changed the title [EPIC] Cleanup Metadata usages Cleanup Metadata usages Oct 9, 2023
@cthoyt cthoyt marked this pull request as ready for review October 9, 2023 14:41
@cthoyt cthoyt requested a review from matentzn October 9, 2023 14:49
matentzn
matentzn reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No larger concern, just 1 or 2 questions.

src/sssom/constants.py Show resolved Hide resolved
src/sssom/io.py Show resolved Hide resolved
@cthoyt cthoyt merged commit 563387e into master Oct 12, 2023
6 checks passed
@cthoyt cthoyt deleted the update-metadata-merging branch October 12, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthoyt @matentzn