Improve CURIE and IRI validation #459
Merged
+588
−532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `curies` implements CURIE and IRI validation checks in biopragmatics/curies#90, this PR replaces the SSSOM functionality. Note, this requires passing a Converter to a few functions that previously didn't need one, but it seems like a small price to pay for data integrity This PR also adds deprecation warnings for `sssom.util.is_curie` and `sssom.util.is_iri` since other packages might be using these.
matentzn
reviewed
Nov 6, 2023
|
Aweeeesome! Thanks! |
matentzn
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
curiesimplements CURIE and IRI validation checks in biopragmatics/curies#90, this PR replaces the SSSOM functionality.Note, this requires passing a Converter to a few functions that previously didn't need one, but it seems like a small price to pay for data integrity
This PR also adds deprecation warnings for
sssom.util.is_curieandsssom.util.is_irisince other packages might be using these.