Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing sssom-schema update #511

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Testing sssom-schema update #511

wants to merge 10 commits into from

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Apr 2, 2024

Here are the steps that were followed in this branch

  • sssom convert https://raw.githubusercontent.com/mapping-commons/sssom-py/master/tests/data/basic.tsv -o tests/data/basic.sssom2.rdf -O rdf
  • Changed self.rdf_graph_file = f"{test_data_dir}/basic.sssom2.rdf"
  • Ran pytest tests/test_parsers.py -k test_parse_sssom_rdf
    • Errored out
  • Downgraded sssom-schema to 0.15.0 [poetry add [email protected]]
  • Ran pytest tests/test_parsers.py -k test_parse_sssom_rdf again
    • This time it passes.

@hrshdhgd hrshdhgd requested a review from matentzn April 2, 2024 17:49
@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Apr 2, 2024

Updates:

  • I have deleted the duplicate basic.sssom2.rdf file
  • Also, the toml file corresponded to an older version of poetry. I have updated it to the latest version. Hence the difference.

python = "^3.9"
click = ">=8.1.7"
curies = ">=0.7.8"
pandas = ">=2.2.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause a problem like it did with #432

cc @kevinschaper

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might, but we can solve it on the cat-merge / kgx side this time, I say go for it

pyyaml = "^6.0.1"
rdflib = ">=6.0.0"
PyYAML = "^6.0.1"
rdflib = ">=7.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty steep. Necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well if it isn't breaking for us.

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Apr 2, 2024

ok, I have this PR and #510 . #510 is a minor update. This one updates minimum python version as well. This PR covers #510 and more. We have a choice to make.

@hrshdhgd hrshdhgd requested a review from matentzn April 2, 2024 22:22
@matentzn matentzn marked this pull request as draft April 4, 2024 09:29
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to draft mode because:

  1. I am worried of breaking the monarch pipelines again with pandas 2
  2. Chris suggests to introduce 3.9+ dependencies in a separate release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants