Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MD-2882: Modified hive change metadata scripts #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MD-2882: Modified hive change metadata scripts #403

wants to merge 1 commit into from

Conversation

prasadns14
Copy link
Contributor

@Agirish, please review

@Agirish
Copy link
Member

Agirish commented Jan 10, 2018

Hey Prasad, can you please split this into 2 PRs - one for the TPC-DS script changes and one for the change metadata baseline changes?

@prasadns14
Copy link
Contributor Author

@Agirish, done

Agirish
Agirish reviewed Jan 11, 2018
View reviewed changes
framework/resources/Datasources/hive_storage/change_metadata2.ddl
date_col int,
time_col bigint,
date_col date,
time_col string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - why "string"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change metadata

Agirish
Agirish reviewed Jan 11, 2018
View reviewed changes
framework/resources/Datasources/hive_storage/change_metadata2.ddl
float_col int,
double_col float,
bool_col int
interval_col string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change metadata

@prasadns14 prasadns14 changed the title MD-2954: Fixed TPCDS100 hive datagen script MD-2882: Modified hive change metadata scripts Jan 11, 2018
@Agirish
Copy link
Member

Agirish commented Jan 19, 2018

Hey Prasad, is this PR still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agirish Agirish Agirish left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasadns14 @Agirish