Fix ref tag case sensitivity #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, there is still a slight issue with this, I'll sort it. |
russss
force-pushed
the
ref_case_sensitivity
branch
from
2dc83f4
to
5ca2215
Compare
|
Thanks for the PR! There are two things missing now: |
russss
force-pushed
the
ref_case_sensitivity
branch
from
5ca2215
to
1a5342a
Compare
At the moment it's not possible to correctly use `ref:` tag names which contain uppercase characters (I'm not a huge fan of them but it has become common to namespace `ref:` tags with the uppercase country code). Overpass is case sensitive but osm_conflate currently lowercases all tag names. This change uses the CaseInsensitiveDict class from `requests` (which is already a dependency) in SourcePoint to avoid tag name case issues.
russss
force-pushed
the
ref_case_sensitivity
branch
from
1a5342a
to
f6b31b4
Compare
|
Oops, yes. Fixed. |
|
And now it won't take I'll have to check the code and examples to confirm that lowercase keys were not a requirement for some obscure process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment it's not possible to correctly use
ref:tag keys which contain uppercase characters (I'm not a huge fan of them but it has become common to namespaceref:tags with the uppercase country code).Overpass is case sensitive but osm_conflate currently lowercases all tag names. This change uses the CaseInsensitiveDict class from
requests(which is already a dependency) in SourcePoint to avoid tag name case issues.I've tested this and it now behaves correctly with a ref tag key containing uppercase characters.