-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InterruptedException to Exception change #2909
Open
michal-szklarski-jmp
wants to merge
7
commits into
mapsplugin:multiple_maps
Choose a base branch
from
michal-szklarski-jmp:patch-1
base: multiple_maps
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
InterruptedException to Exception change #2909
michal-szklarski-jmp
wants to merge
7
commits into
mapsplugin:multiple_maps
from
michal-szklarski-jmp:patch-1
Commits on Mar 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1e27920 - Browse repository at this point
Copy the full SHA 1e27920View commit details
Commits on Apr 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6ad38c8 - Browse repository at this point
Copy the full SHA 6ad38c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d015687 - Browse repository at this point
Copy the full SHA d015687View commit details
Commits on May 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for de0bee2 - Browse repository at this point
Copy the full SHA de0bee2View commit details
Commits on Aug 17, 2020
-
Probably the bug of the Google Maps SDK for Android v3 beta
Configuration menu - View commit details
-
Copy full SHA for 420e907 - Browse repository at this point
Copy the full SHA 420e907View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdb7af4 - Browse repository at this point
Copy the full SHA bdb7af4View commit details
Commits on Jul 13, 2022
-
InterruptedException to Exception change
We're observing the enormous number of crashes (coming mostly from Firebase's stack trace) in PluginMarker.java file. The line 167 is generating an Exception that is not being predicted by the Try-Catch where is inserted (lines 149 - 185), which is specifically only catching InterruptedException types. Simply replacing "InterruptedException" with "Exception" will solve the problem, as then the catch will be able to catch all Exception types and avoid the crash.
Configuration menu - View commit details
-
Copy full SHA for fe62d4c - Browse repository at this point
Copy the full SHA fe62d4cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.