Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute elevation #32

Merged
merged 14 commits into from
Dec 5, 2023
Merged

Compute elevation #32

merged 14 commits into from
Dec 5, 2023

Conversation

jonathanlurie
Copy link
Collaborator

@jonathanlurie jonathanlurie commented Nov 27, 2023

RD-180

Objective

Compute the elevation of a point or a batch of point, using efficient caching.

Description

Two new submodules are now available: elevation and math

Acceptance

This was tested mainly with checking the elevation of some major mountain peaks around the world.

Checklist

  • I have added relevant info to the CHANGELOG.md

@petrsloup petrsloup self-requested a review November 27, 2023 14:18
Copy link
Member

@petrsloup petrsloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there two elevation "examples" ? I see them more as a "playground" during the development to test and tweak the API, but they seem pretty identical except for the actual code snippets in the comments.. wouldn't it be better to have just one file for this?

examples/elevation.html Outdated Show resolved Hide resolved
src/services/math.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
@jonathanlurie jonathanlurie merged commit cead13a into main Dec 5, 2023
1 check passed
@jonathanlurie jonathanlurie deleted the dev-elev2 branch December 5, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants