feat: allows resolving relative public urls into absolute urls #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have this same issue |
|
any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had an issue with using tileserver-gl running behind a proxy in a subdirectory. I also wanted to configure my web clients with relative urls so that map server url was /maps. Mapbox GL requires that urls that come from tileserver-gl are absolute URLs.
This feature enables the server to serve content from subdirectory so that all the relative urls are resolved into absolute urls.
This is an opt-in feature so it won't be enabled by default. You have to specify TILESERVER_GL_RESOLVE_RELATIVE_PUBLIC_URL=true env variable and public_url option for it to be enabled.