Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Only focus focusable nodes #884

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Sep 14, 2024

Part of #844
Closes #843

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.03%. Comparing base (bf1fcd2) to head (faa92d6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/state/src/accessibility.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   76.01%   76.03%   +0.02%     
==========================================
  Files         205      207       +2     
  Lines       23256    23291      +35     
==========================================
+ Hits        17677    17710      +33     
- Misses       5579     5581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review September 18, 2024 20:03
@marc2332 marc2332 merged commit 3ae218d into main Sep 19, 2024
7 checks passed
@marc2332 marc2332 deleted the feat/only-focus-focusable-nodes branch September 19, 2024 16:19
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Only focus focusable accessibility nodes
1 participant