Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: muda integration #945

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: muda integration #945

wants to merge 11 commits into from

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Oct 1, 2024 •
edited
Loading

Closes #782

@marc2332 marc2332 added enhancement 🔥 New feature or request experiment 🧪 labels Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Benchmark for 29e68b5

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.9±0.18ms 106.3±0.40ms -0.56%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.5±0.88ms 25.0±1.14ms +2.04%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1420.3±16.59µs 1419.4±86.07µs -0.06%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 135.9±1.08µs 135.6±1.70µs -0.22%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.6±0.72ms 24.1±0.28ms -2.03%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1723.1±7.11µs 1716.8±8.18µs -0.37%
benchmarks/size=19531 depth=7 wide=5 mode=cached 309.8±6.02µs 307.6±2.82µs -0.71%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.02ms 2.6±0.03ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 419.5±44.10µs 422.3±142.25µs +0.67%
benchmarks/size=54241 depth=5 wide=15 mode=cached 243.5±11.70µs 257.4±50.24µs +5.71%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.10ms 6.4±0.21ms 0.00%

@marc2332 marc2332 changed the base branch from main to feat/event-loop-builder-hook October 2, 2024 19:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Benchmark for 02bd754

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 108.9±0.68ms 109.2±0.67ms +0.28%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 29.5±1.08ms 29.6±1.52ms +0.34%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1566.5±54.09µs 1422.3±66.91µs -9.21%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 151.5±2.17µs 137.7±3.50µs -9.11%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 27.8±0.99ms 28.5±1.57ms +2.52%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1840.0±173.89µs 1824.6±122.32µs -0.84%
benchmarks/size=19531 depth=7 wide=5 mode=cached 390.1±78.24µs 487.2±68.35µs +24.89%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.1±0.57ms 3.0±0.37ms -3.23%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 421.1±53.26µs 426.1±92.65µs +1.19%
benchmarks/size=54241 depth=5 wide=15 mode=cached 371.7±83.29µs 484.0±100.06µs +30.21%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.1±0.76ms 8.0±0.76ms +12.68%

Base automatically changed from feat/event-loop-builder-hook to main October 6, 2024 08:11
@github-actions GitHub Actions
Copy link

Benchmark for a2698dd

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 105.9±1.97ms 105.2±0.58ms -0.66%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.7±1.00ms 25.8±1.61ms +4.45%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1403.7±16.62µs 1420.0±94.97µs +1.16%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.4±1.55µs 134.1±1.85µs -0.22%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.5±0.84ms 24.1±1.02ms -1.63%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1753.5±12.41µs 1691.3±9.30µs -3.55%
benchmarks/size=19531 depth=7 wide=5 mode=cached 320.7±16.27µs 316.4±14.32µs -1.34%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.02ms 2.7±0.03ms +3.85%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 424.3±136.85µs 418.9±94.12µs -1.27%
benchmarks/size=54241 depth=5 wide=15 mode=cached 272.5±132.95µs 265.2±35.83µs -2.68%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.5±0.22ms 6.4±0.29ms -1.54%

@github-actions GitHub Actions
Copy link

Benchmark for 2d588cb

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 102.1±1.99ms 102.1±1.97ms 0.00%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 22.9±0.39ms 22.9±0.78ms 0.00%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1401.7±32.91µs 1372.5±39.43µs -2.08%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 131.8±3.30µs 132.0±3.57µs +0.15%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.3±0.96ms 23.2±0.39ms -0.43%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1649.5±35.30µs 1696.7±41.20µs +2.86%
benchmarks/size=19531 depth=7 wide=5 mode=cached 305.2±7.59µs 299.3±6.05µs -1.93%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.05ms 2.5±0.06ms -3.85%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 402.9±10.23µs 412.1±125.63µs +2.28%
benchmarks/size=54241 depth=5 wide=15 mode=cached 240.8±12.53µs 239.2±8.00µs -0.66%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.18ms 6.3±0.15ms +1.61%

@github-actions GitHub Actions
Copy link

Benchmark for 647377a

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 110.9±0.49ms 105.8±0.42ms -4.60%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.9±0.49ms 24.1±1.22ms +0.84%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1412.8±10.42µs 1421.2±7.67µs +0.59%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.8±1.59µs 134.9±1.80µs +0.07%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.9±0.48ms 23.6±0.37ms -1.26%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1715.7±7.79µs 1707.1±11.31µs -0.50%
benchmarks/size=19531 depth=7 wide=5 mode=cached 306.9±2.72µs 309.4±7.37µs +0.81%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.02ms 2.6±0.01ms -3.70%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 420.6±135.04µs 417.5±61.52µs -0.74%
benchmarks/size=54241 depth=5 wide=15 mode=cached 247.2±15.58µs 245.5±7.67µs -0.69%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.3±0.08ms 6.4±0.05ms +1.59%

@github-actions GitHub Actions
Copy link

Benchmark for c211bc7

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 107.6±1.35ms 105.0±2.08ms -2.42%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.5±0.59ms 23.7±1.38ms +0.85%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1412.2±40.80µs 1415.2±41.33µs +0.21%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 133.6±1.45µs 134.6±1.44µs +0.75%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.5±1.15ms 23.6±0.42ms -3.67%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1707.0±7.18µs 1718.9±65.33µs +0.70%
benchmarks/size=19531 depth=7 wide=5 mode=cached 308.3±2.47µs 306.9±2.33µs -0.45%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.9±0.05ms 2.6±0.13ms -10.34%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 417.9±152.17µs 417.1±112.01µs -0.19%
benchmarks/size=54241 depth=5 wide=15 mode=cached 248.8±88.11µs 241.8±7.56µs -2.81%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.09ms 6.4±0.34ms 0.00%

@github-actions GitHub Actions
Copy link

Benchmark for 3cbe98e

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.6±3.51ms 105.6±0.55ms -0.94%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.9±0.88ms 25.5±0.98ms -1.54%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1418.5±14.41µs 1407.9±9.68µs -0.75%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.2±2.69µs 134.0±1.00µs -0.15%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.3±0.66ms 25.4±0.42ms +0.40%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1703.9±5.97µs 1725.0±7.99µs +1.24%
benchmarks/size=19531 depth=7 wide=5 mode=cached 310.2±4.68µs 313.0±6.63µs +0.90%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.06ms 2.6±0.01ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 416.7±86.83µs 418.6±110.63µs +0.46%
benchmarks/size=54241 depth=5 wide=15 mode=cached 247.5±15.33µs 250.2±18.92µs +1.09%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.3±0.05ms 7.4±0.64ms +1.37%

@codecov Codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.00%. Comparing base (3a2e73a) to head (5f99684).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #945   +/-   ##
=======================================
  Coverage   74.00%   74.00%           
=======================================
  Files         213      213           
  Lines       24316    24316           
=======================================
  Hits        17995    17995           
  Misses       6321     6321

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Benchmark for ab52624

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.1±0.26ms 105.8±0.49ms -0.28%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.5±0.63ms 23.8±2.12ms +1.28%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1437.5±6.94µs 1421.4±46.19µs -1.12%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 135.8±1.54µs 135.2±1.07µs -0.44%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.2±0.22ms 23.9±0.34ms +3.02%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1704.9±32.12µs 1733.1±63.71µs +1.65%
benchmarks/size=19531 depth=7 wide=5 mode=cached 308.2±2.59µs 316.9±8.22µs +2.82%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.02ms 2.6±0.04ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 421.3±133.94µs 419.6±132.27µs -0.40%
benchmarks/size=54241 depth=5 wide=15 mode=cached 246.3±13.10µs 243.3±10.94µs -1.22%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.06ms 6.4±0.14ms 0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement 🔥 New feature or request experiment 🧪
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement: Support native menus using Muda
1 participant
@marc2332