fix: absolute positioning doesn't ignore the padding of the parent element

[Aiving]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.34%. Comparing base (00ca902) to head (a5c16c9).

Files with missing lines	Patch %	Lines
crates/torin/src/measure.rs	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   74.34%   74.34%   -0.01%     
==========================================
  Files         214      214              
  Lines       24739    24742       +3     
==========================================
+ Hits        18393    18395       +2     
- Misses       6346     6347       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marc2332]

What about the root node when measuring it in torin.rs?

[Aiving]

What about the root node when measuring it in torin.rs?

I'm not sure I understand correctly what the question is about. Do you mean absolute positioning of the root element itself or something else?

[marc2332]

What about the root node when measuring it in torin.rs?

I'm not sure I understand correctly what the question is about. Do you mean absolute positioning of the root element itself or something else?

Torin starts measuring from the root node by calling measure_node, you changed how this method is called when measuring descendants but not when is called upon the root node of the measurement.

By root node I don't specifically refer to the root node of the app but to the root node from where the measuring starts, which could be different is the measure is incremental.

[marc2332]

Perhaps your way is not a good approach, if the 3 places where this function is called require some special logic maybe its better to move the logic inside or create a simple function to abstract it

[marc2332]

I don't agree with this, if an element is absolute I still think it should consider the parent's padding. I recently added the global position too, maybe that fits your use case better?