Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lost subscription when BackgroundJobServer being stopped #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niki-timofe
Copy link

Fix lost subscription when BackgroundJobServer being stopped and then recreated

Fixes #89

@niki-timofe niki-timofe marked this pull request as ready for review July 16, 2020 16:52
@marcoCasamento
Copy link
Owner

Sorry for the very long time, I'd like to merge the request but I don't fully understand the code. Was an error raised on CancellationToken Request ? how does it relates to #89 ?

@niki-timofe
Copy link
Author

niki-timofe commented Apr 26, 2021

Oh, it was a very long time ago. But as far as I remember, we faced an issue, while trying to implement switching between data-centers mechanics.
Our idea was to have running, but passive instances in reserving DC. The issue is that when switching, server won't receive new jobs, because ISubscriber and ResetEvent have been disposed.

Seems like it relates to #89 by the error message.

For now, fork with my changes is running in production, and there are no issues with Redis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants