Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加资源文件是以单独文件的形式保存,但是lint 问题中存在location的处理 #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 31 additions & 11 deletions src/main/groovy/com/droidtitan/lintcleaner/LintCleanerTask.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class LintCleanerTask extends DefaultTask {
final String ISSUE_XML_TAG = "issue"
final String LINE_XML_TAG = "line"
final String LOCATION_XML_TAG = "location"
final String MESSAGE_XML_TAG = "message"

final Map<String, List<String>> filePathToLines = new HashMap<String, ArrayList<String>>()
List<String> excludes
Expand Down Expand Up @@ -58,31 +59,50 @@ class LintCleanerTask extends DefaultTask {
NodeList locations = issue.getElementsByTagName(LOCATION_XML_TAG)

if (locations.length == 1) {
processLocation(locations.item(0) as Element)
processLocation(issue, locations.item(0) as Element)
} else {
locations.each {
processLocation(it as Element)
processLocation(issue, it as Element)
}
}
}
}
}

/** Removes unused files or adds filePath to map for processing by @removeUnusedLinesInResFiles. */
void processLocation(Element location) {
void processLocation(Element issue, Element location) {
String line = location.getAttribute(LINE_XML_TAG)
String filePath = location.getAttribute(FILE_PATH_XML_TAG)
File file = new File(filePath)

if (line.empty) {
File file = new File(filePath)
file.delete()
println "Removed $file.name"
} else {
List<String> lineNumbers = filePathToLines.get(filePath)
lineNumbers = lineNumbers ? lineNumbers : new ArrayList<String>()
lineNumbers.add(line)
filePathToLines.put(filePath, lineNumbers)
deleteFile(file)
return;
}
// if resource name equals resource file name, delete file
String message = issue.getAttribute(MESSAGE_XML_TAG);
println message
def matcher = message =~ "\\`(.*)\\`"
if (matcher.count > 0) {
def resStr = matcher[0][1]
def resName = resStr.tokenize('.')[2];
def resFileName = file.name.tokenize('.')[0]
if (resFileName == resName) {
deleteFile(filePath)
return;
}
}
// handle resource in common resource file
List<String> lineNumbers = filePathToLines.get(filePath)
lineNumbers = lineNumbers ? lineNumbers : new ArrayList<String>()
lineNumbers.add(line)
filePathToLines.put(filePath, lineNumbers)
}

void deleteFile(File file)
{
file.delete()
println "Removed $file.name"
}

/** Removes unused resources from single files like strings.xml, color.xml etc. */
Expand Down