LPD-19861 | master #336
Open
LPD-19861 | master #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…facet selections across searches' configuration https://liferay.atlassian.net/browse/LPD-21755
…acetSelections field in the search request https://liferay.atlassian.net/browse/LPD-21755
…ches' configuration in Search Options widget https://liferay.atlassian.net/browse/LPD-21755
…ojects/LPP/components Localization seems to be part of core infra team, so changing it accordingly
…ce Management (Echo)
…M", update test.properties properly and sets the correct main component
…olbar that are filtering without opening a modal window
# breaking
## What modules/apps/layout/layout-utility-page-service/src/main/java/com/liferay/layout/utility/page/service/impl/LayoutUtilityPageEntryLocalServiceImpl.java
Adding parameters String friendlyURL and boolean privateLayout to method addLayoutUtilityPageEntry, changing its signature from
public LayoutUtilityPageEntry addLayoutUtilityPageEntry(
String externalReferenceCode, long userId, long groupId,
long plid, long previewFileEntryId,
boolean defaultLayoutUtilityPageEntry, String name, String type,
long masterLayoutPlid, ServiceContext serviceContext)
throws PortalException
to
public LayoutUtilityPageEntry addLayoutUtilityPageEntry(
String externalReferenceCode, long userId, long groupId,
String friendlyURL, long plid, long previewFileEntryId,
boolean defaultLayoutUtilityPageEntry, String name, String type,
long masterLayoutPlid, boolean privateLayout,
ServiceContext serviceContext)
throws PortalException
## Why
This change is required to have the ability to create a utility page with a public layout.
----
# breaking
## What modules/apps/layout/layout-utility-page-service/src/main/java/com/liferay/layout/utility/page/service/impl/LayoutUtilityPageEntryServiceImpl.java
Adding parameters String friendlyURL and boolean privateLayout to method addLayoutUtilityPageEntry, changing its signature from
public LayoutUtilityPageEntry addLayoutUtilityPageEntry(
String externalReferenceCode, long groupId, long plid, long previewFileEntryId,
boolean defaultLayoutUtilityPageEntry, String name, String type,
long masterLayoutPlid, ServiceContext serviceContext)
throws PortalException
to
public LayoutUtilityPageEntry addLayoutUtilityPageEntry(
String externalReferenceCode, long groupId, String friendlyURL,
long plid, long previewFileEntryId,
boolean defaultLayoutUtilityPageEntry, String name, String type,
long masterLayoutPlid, boolean privateLayout,
ServiceContext serviceContext)
throws PortalException
## Why
This change is required to have the ability to create a utility page with a public layout.
----
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://issues.liferay.com/browse/LPD-19861