Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always terminate line #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

eykamp
Copy link
Contributor

@eykamp eykamp commented Mar 24, 2018

We should always be terminating the line, unless there is good reason not to. If we don't clients may not know when the server response is complete.

@eykamp
Copy link
Contributor Author

eykamp commented Apr 14, 2018

Is this something you might want to merge? If you don't like it, perhaps I can find a different way to solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant