fix: make sure that metadata is not deleted when schemas are calculat…

…ed more than once. Closes #799

dataclasses_avroschema/fields/base.py

@@ -32,10 +32,17 @@ class Field:
     metadata: typing.Dict = dataclasses.field(default_factory=dict)
     model_metadata: utils.SchemaMetadata = dataclasses.field(default_factory=utils.SchemaMetadata)
     extra_default_types_allowed: typing.Tuple = dataclasses.field(default_factory=tuple)
+    # This is the metadata that the end user has defined in the dataclasses.Field or pydantic.Field
+    metadata_to_exclude: typing.List[str] = dataclasses.field(
+        default_factory=lambda: [
+            "exclude_default",
+            "inner_name",
+        ]
+    )
 
     def __post_init__(self) -> None:
-        self.exclude_default = self.metadata.pop("exclude_default", False)  # type: ignore
-        self.inner_name = self.metadata.pop("inner_name", None)  # type: ignore
+        self.exclude_default = self.metadata.get("exclude_default", False)  # type: ignore
+        self.inner_name = self.metadata.get("inner_name", None)  # type: ignore
 
     @property
     def avro_type(self) -> typing.Union[str, typing.Dict]:  # type: ignore
@@ -53,7 +60,7 @@ def get_singular_name(name: str) -> str:
         return inflection.singularize(name)
 
     def get_metadata(self) -> typing.List[typing.Tuple[str, str]]:
-        return [(name, value) for name, value in self.metadata.items()]
+        return [(name, value) for name, value in self.metadata.items() if name not in self.metadata_to_exclude]
 
     def render(self) -> OrderedDict:
         """

tests/schemas/pydantic/test_pydantic.py

@@ -59,6 +59,9 @@ class Meta:
             schema_doc = False
 
     assert User.avro_schema() == json.dumps(user_avro_json)
+    # We execute again the test to make sure that that the result is the same
+    # related to https://github.com/marcosschroh/dataclasses-avroschema/issues/799
+    assert User.avro_schema() == json.dumps(user_avro_json)
 
 
 def test_pydantic_record_schema_with_metadata():