Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix CI create DB error #511

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Investigate and fix CI create DB error #511

merged 9 commits into from
Jan 20, 2025

Conversation

marcua
Copy link
Owner

@marcua marcua commented Jan 19, 2025

Starting with Ubuntu 24.x, nsjail can no longer work with the default security permissions. We'll have to consider a solution for the long-term, but in the short-term, the solution on CI is to turn off some AppArmor protections.

In debugging this issue, I realized that we weren't properly handling the case where the isolated query runner was returning an error that couldn't be parsed as an AybError, so resolved that as well.

@marcua
Copy link
Owner Author

marcua commented Jan 19, 2025

It's this:

image

Which is this

to-do

  • Clean up JSON parsing logic so we still try to parse an AybError and only on failure do we share the unparsed error
  • Try this from the issue (but probably have to migrate off of nsjail eventually)
sudo sysctl -w kernel.apparmor_restrict_unprivileged_unconfined=0
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

@marcua marcua merged commit 86d990e into main Jan 20, 2025
1 check passed
@marcua marcua deleted the fix-create-error branch January 20, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant