add dialog role since no browsers really expose it

marcysutton · Oct 13, 2016 · 31eb6ca · 31eb6ca
1 parent c029d31
commit 31eb6ca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/comparisons/components/modal/html.html b/comparisons/components/modal/html.html
@@ -2,6 +2,7 @@
 	Click Me
 </a>
 
-<dialog class="modal" id="modalDialog1" tabindex="-1">
+<dialog class="modal" id="modalDialog1"
+		tabindex="-1" role="dialog">
   <p>Hello Beautiful!</p>
 </dialog>
diff --git a/index.html b/index.html
@@ -153,7 +153,8 @@ <h4>HTML</h4>
 	Click Me
 &lt;/a&gt;
 
-&lt;dialog class=&quot;modal&quot; id=&quot;modalDialog1&quot; tabindex=&quot;-1&quot;&gt;
+&lt;dialog class=&quot;modal&quot; id=&quot;modalDialog1&quot; 
+		tabindex=&quot;-1&quot; role=&quot;dialog&quot;&gt;
   &lt;p&gt;Hello World!&lt;/p&gt;
 &lt;/dialog&gt;</code></pre>
                 </div>