chore(docs): import defaultAssetExts #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannojg
reviewed
Jul 17, 2024
docs/docs/guides/GETTING_STARTED.mdx
Outdated
| @@ -100,6 +100,9 @@ You'll likely import 3D related files when using react-native-filament. To make | |||
|
|
|||
| ```js | |||
| const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config'); | |||
| const defaultAssetExts = require("metro-config/src/defaults/defaults").assetExts; | |||
There was a problem hiding this comment.
I think expo uses a different import for this? So maybe its better to take the value from the default config?
There was a problem hiding this comment.
I'm not sure how Expo handles it, I've made the update to take value from default config,
hannojg
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick update on documentation about metro resolver
assetExtsMost projects need the default metro extensions, so I think it's useful to indicate this in the documentation.
There are many ways to do it, I let you decide what's your favorite one