-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made headings actual markdown headings #17
Conversation
@arne-broering I believe @ajcraig intentionally changed these to not be headers (and other places) before we moved to this repo because it was causing the sidebar navigation to be too deep. Not having them as headers breaks the links so I'm not sure what is better. @ajcraig What do you think? |
Ah, ok, didn't know that. I just changed those to actual "#" headings, as it would be really helpful to link in the type definitions from the Deployment spec to the App Package spec. |
@@ -132,7 +132,7 @@ metadata: | |||
organization: | |||
- name: Northstar Industrial Applications | |||
site: http://northstar-ida.com | |||
deploymentProfiles: | |||
s: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you may have accidentally deleted some text here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed that
334e934
to
d3a684c
Compare
I added the following lines to
|
❌ @arne-broering the
📝 What should I do to fix it?All proposed commits should include a sign-off in their messages, ideally at the end. ❔ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:
Contributors sign-off that they adhere to these requirements by adding a
Git even has a
|
1 similar comment
❌ @arne-broering the
📝 What should I do to fix it?All proposed commits should include a sign-off in their messages, ideally at the end. ❔ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:
Contributors sign-off that they adhere to these requirements by adding a
Git even has a
|
f94c5cb
to
eecc4d9
Compare
❌ @arne-broering the
📝 What should I do to fix it?All proposed commits should include a sign-off in their messages, ideally at the end. ❔ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:
Contributors sign-off that they adhere to these requirements by adding a
Git even has a
|
eecc4d9
to
e083c56
Compare
❌ @arne-broering the
📝 What should I do to fix it?All proposed commits should include a sign-off in their messages, ideally at the end. ❔ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:
Contributors sign-off that they adhere to these requirements by adding a
Git even has a
|
e083c56
to
35f6847
Compare
I did this so that we can have anchor links to headings
Description
Please provide a concise summary of the changes and their motivation.
Issues Addressed
List and link all the issues addressed by this PR.
Change Type
Please select the relevant options:
Checklist