Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added edit option to the template #35

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Added edit option to the template #35

merged 1 commit into from
Sep 30, 2024

Conversation

phil-abb
Copy link
Contributor

Description

Added a third option to the PR template for changes that are just editing existing content

Issues Addressed

n/a

Change Type

Please select the relevant options:

  • Fix (change that resolves an issue)
  • New enhancement (change that adds specification content)

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established patterns, and best practices.

@phil-abb phil-abb requested a review from a team as a code owner September 26, 2024 10:57
@phil-abb
Copy link
Contributor Author

@stormc @ajcraig @seanmcilroy29 - I created a PR to update the PR template to include a "change type" option for content edits.

@phil-abb phil-abb mentioned this pull request Sep 26, 2024
Closed
9 tasks
ajcraig
ajcraig approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@ajcraig ajcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition to integrate with the "Pre-draft" stage of the specification we are in.

@phil-abb phil-abb force-pushed the pdp/pr-template-update branch from e598181 to b221149 Compare September 27, 2024 14:52
@phil-abb phil-abb merged commit 035aa24 into pre-draft Sep 30, 2024
2 checks passed
@phil-abb phil-abb deleted the pdp/pr-template-update branch October 11, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcraig ajcraig ajcraig approved these changes

@arne-broering arne-broering arne-broering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-abb @arne-broering @ajcraig