Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discrepancy between helm and configuration #39

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

gecube
Copy link
Contributor

@gecube gecube commented Oct 15, 2024

Hi!

It looks like that there is a discrepancy between list of helm values and configuration of app. I tried to fix it. I am kindly asking to review and accept if the PR is correct.

@gecube gecube requested a review from a team as a code owner October 15, 2024 06:22
Copy link

linux-foundation-easycla bot commented Oct 15, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@ajcraig ajcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the find @gecube, approved.

@ajcraig ajcraig merged commit d350674 into margo:pre-draft Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants