Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display alias for addresses #180

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Display alias for addresses #180

merged 5 commits into from
Apr 9, 2024

Conversation

quentin-burg
Copy link
Collaborator

@quentin-burg quentin-burg commented Apr 3, 2024

Related to #106

utils/getTzktAlias.ts Outdated Show resolved Hide resolved
pages/[walletAddress]/history.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
components/history/HistoryTransfer.tsx Show resolved Hide resolved
components/Sidebar.tsx Outdated Show resolved Hide resolved
components/Sidebar.tsx Outdated Show resolved Hide resolved
components/Alias.tsx Outdated Show resolved Hide resolved
components/Alias.tsx Outdated Show resolved Hide resolved
@Pilou97
Copy link
Collaborator

Pilou97 commented Apr 4, 2024

I think there is an issue in the copy pasting of the address (But I am running on Arch Linux, the error can be on my side):

There is still the tooltip "Copy address" but it does not copy it

@Pilou97
Copy link
Collaborator

Pilou97 commented Apr 4, 2024

Also should we display the alias or the address in the menu entry?

@Pilou97 Pilou97 merged commit c37e080 into main Apr 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants