feat: Add support for watch flag #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a feature to support the watch mode in neotest. In the previous implementation, the user had the ability to run tests but there was no provision to watch the files and run the tests when changes occur. This feature is particularly helpful while doing test-driven development where code changes frequently. 1. Added key mappings examples in README.md to trigger watch mode. 2. Refactored the build_spec function in init.lua to support watch mode. It now includes command flag "--watch=false" in the command list instead of --run. 3. Added a new function stream in util.lua which continuously reads file data and triggers a callback function for new data. This is used to watch the test files and run tests on file change. closes marilari88#27 Signed-off-by: marcoSven <[email protected]>
|
@marcoSven Big thanks for your contribution! I left a couple of comments for you. One concern though: I noticed when testing the PR that the vitest process in watch mode sticks around until Neovim shuts down or Neotest stop is called. This could lead to a bunch of unwanted background processes if we're running lots of tests in watch mode. How do you handle it? |
marilari88
reviewed
Feb 28, 2024
Co-authored-by: Marco Ilari <[email protected]>
Co-authored-by: Marco Ilari <[email protected]>
I think this is the same with the Jest adapter. |
marilari88
approved these changes
Feb 29, 2024
|
@marcoSven thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a feature to support the watch mode in neotest. In the previous implementation, the user had the ability to run tests but there was no provision to watch the files and run the tests when changes occur. This feature is particularly helpful while doing test-driven development where code changes frequently.
Screen.Recording.2024-02-27.at.18.25.37.mov
closes #27