-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support nested describe #55
Conversation
hi @AbaoFromCUG @joshmedeski Thanks for your huge contribution! Feel free to you take a look at the actions that are failing? in other case I will do as soon as I can |
f2fcebb
to
8d0df46
Compare
I had removed |
Hey @AbaoFromCUG can you clarify why I'm authored on this commit? I don't remember helping you write any of this code. Maybe it was indirect and I'm missing something. If this was done by mistake can you remove me from the commit? |
@joshmedeski I am sorry to bother you, I guess that the maintainer @marilari88 add you to reviewer. |
Just to confirm, it says I authored the commit, but I did not. Please check your git config or change the git commit message on this PR so that you are the only author, thanks. |
@AbaoFromCUG ping |
Any updates here? Very excited for these changes and fixes!! Thanks! |
I have revert the modify about I test in 3 type configuration manually, and all test cases are passed
1. Plain Config require("neotest").setup({
adapters = {
require("neotest-vitest")({
vitestCommand = "bunx vitest",
}),
}
}) 2. Your nvim lua configfrom require("neotest").setup({
adapters = {
require("neotest-vitest")({
vitestCommand = "bunx vitest",
}),
},
quickfix = { open = true },
output = {
enabled = true,
open = "botright split | resize 15",
}
})
3. My config
require("overseer").setup({
templates = { "builtin" },
strategy = {
"toggleterm",
direction = "float",
use_shell = true,
},
})
---@diagnostic disable-next-line: duplicate-set-field
require("overseer.shell").escape_cmd = function(cmd)
return table.concat(vim.tbl_map(vim.fn.shellescape, cmd), " ")
end
require("neotest").setup({
adapters = {
require("neotest-vitest")({
vitestCommand = "bunx vitest",
}),
},
consumers = { overseer = require("neotest.consumers.overseer") },
}) Could you checkout and test it? thanks |
@marilari88 fix v0.9.5 compatible issue |
This is awesome!! Thanks so much for this PR! Quick question to confirm, this does NOT resolve the it.each() dynamic parameterized names issue correct? |
No. Don't related to |
@AbaoFromCUG this PR seems to break finding any of the tests for me. -- before
query = query .. string.gsub(query, "arrow_function", "function_expression")
--- after
query = query .. string.gsub(query, "arrow_function", "function") is it just on my treesitter that this issue occurs? Using function_expression in the query gives me 0 results. |
Features
describe
#32functio(){}
test implement function keyword in describe/test is not parsed correctly #33json reporter's result
toneotest Tree
init.vim
tominimal_init.vim
for simplify unittest withneotest-plenary
,minimal_init.vim
is the default start-up script.Fix
json reporter
's output file parse issue Tests always show as failed in gutter sign and summary even though output shows passed #48