Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounds check when pulling item for page. Preemptive return if no image v... #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

colinhumber
Copy link

...iewer available.

Quickly tapping the forward or backwards buttons would cause a crash as the right/leftPressed: methods would be called in rapid succession before they were disabled causing -itemAtIndex: to try and pull an item out of bounds of galleryItems. Also included the nil check for imageViewController before adding it to the pageController.

@colinhumber
Copy link
Author

Also included properly setting the toolbar on the iPhone to 32px when in landscape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants