Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space-delimited list of events support for triggerMethod #3457

Conversation

nlhuykhang
Copy link
Contributor

Proposed changes

  • triggerMethod supports space-delimited list of events

Link to the issue:
#2937

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0bbc3f3 on nlhuykhang:trigger-method-support-space-delimited-events into 11a9d43 on marionettejs:next.

Copy link
Collaborator

@blikblum blikblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggerMethod is a function called a lot in the Marionette hot pathes. So i am against increasing its complexity. There will be performance impact out of the box for all users regardless if they are using this feature or not

In fact recent changes go in the direction of minimize its usage.

@paulfalgout
Copy link
Member

Yeah I agree that, in the very least, any change like this would need to be perf scrutinized to the nth degree. I think the help wanted tag might be misplaced. I think this issue is entirely dependent on the possible replacement of Backbone.trigger if/when that happens.. if/when the Bb API needs to be upheld.

@nlhuykhang
Copy link
Contributor Author

Close this as it is not needed

@nlhuykhang nlhuykhang closed this Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants