Added live example #3526
Merged
Added live example #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfalgout
requested changes
Nov 8, 2017
docs/marionette.region.md
Outdated
| @@ -56,6 +56,8 @@ var App = Mn.Application.extend({ | |||
| }); | |||
| ``` | |||
|
|
|||
| [Live example](http://jsfiddle.net/charlyjazz/gze5ykov/6/) | |||
There was a problem hiding this comment.
this looks good. would you be up for swapping the router to Backbone.Router?
AppRouter will be available as a separate lib for v4, so rather than do this now and update it in a few weeks, using Backbone's router would keep this example solid for v4 as well.
There was a problem hiding this comment.
Ready. I have updated the fiddle. Check it
Add live example for 'Defining the Application Region'
paulfalgout
approved these changes
Nov 9, 2017
|
👏 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added live example in the Region Documentation
Proposed changes
Link to the issue: Issue #3209