Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo fix in marionette functions doc #3597

Closed
wants to merge 1 commit into from
Closed

typo fix in marionette functions doc #3597

wants to merge 1 commit into from

Conversation

birbilis
Copy link

@birbilis birbilis commented May 7, 2018

f is mentioned in the text, plus using foo would confuse the user anyway

Proposed changes

Link to the issue:

@birbilis
typo fix in marionette functions doc
290a14d 
f is mentioned in the text, plus using foo would confuse the user anyway
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 290a14d on birbilis:patch-1 into 590c87a on marionettejs:master.

@paulfalgout paulfalgout self-assigned this May 10, 2018
scott-w
scott-w approved these changes May 17, 2018
View reviewed changes
Copy link
Member

@scott-w scott-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We’ll just need to update the fiddle on our side

@paulfalgout
Copy link
Member

This is getting addressed as part of #3611

@paulfalgout paulfalgout closed this Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scott-w scott-w scott-w approved these changes

Assignees

@paulfalgout paulfalgout

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@birbilis @coveralls @paulfalgout @scott-w