fix clearColor

markaren · Feb 27, 2024 · d5fc5bb · d5fc5bb
1 parent 680df91
commit d5fc5bb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/include/threepp/scenes/Scene.hpp b/include/threepp/scenes/Scene.hpp
@@ -34,7 +34,7 @@ namespace threepp {
 
         [[nodiscard]] std::shared_ptr<Texture> texture() const;
 
-        operator bool() const;
+        [[nodiscard]] bool empty() const;
 
     private:
         bool hasValue_{false};

diff --git a/src/threepp/renderers/gl/GLBackground.cpp b/src/threepp/renderers/gl/GLBackground.cpp
@@ -28,7 +28,7 @@ void GLBackground::render(GLRenderList& renderList, Object3D* scene) {
         cubemaps.get(background->texture().get());
     }
 
-    if (!background) {
+    if (!background || (background && background->empty()) ) {
 
         setClear(clearColor, clearAlpha);
 

diff --git a/src/threepp/scenes/Scene.cpp b/src/threepp/scenes/Scene.cpp
@@ -42,7 +42,7 @@ std::shared_ptr<Texture> Background::texture() const {
     return texture_;
 }
 
-Background::operator bool() const {
+bool Background::empty() const{
 
-    return hasValue_;
+    return !hasValue_;
 }