do save off default references also when creating a new datamap #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also do // Save off default references step when creating a new datamap, to make it more stable when loading d3 and topojson dependencies after datamaps itself I came across this issue when using nuxtjs and conditionally loading the external libraries in, idk if this is relevant in other situations too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also do
// Save off default referencesstep when instanciating a new datamap, to make it more stable when loading d3 and topojson dependencies after datamaps itselfI came across this issue when using nuxtjs and conditionally loading the external libraries in, idk if this is relevant in other situations too