Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): improve type inference for attr tags #295

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

LuLaValva
Copy link
Member

Description

  • Tag parameters for attr tags now have proper types without need for being explicit
    my-tag
      @attrTag
      @attrTag|data|
        ${data.a}
            // ^ inferred!

Note

When there is an error in certain attr tags now, hoisting breaks and an additional error shows up on the first attr tag in addition to the broken one. This is evident in the recursive-input-scope-hoist, but since that's not really the purpose of the test I modified it to remove the error.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@LuLaValva LuLaValva self-assigned this Nov 6, 2024
Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 0dc59fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/language-server Patch
@marko/type-check Patch
marko-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva merged commit 3a713ee into main Nov 11, 2024
4 checks passed
@LuLaValva LuLaValva deleted the attr-tag-ts-improvement branch November 11, 2024 23:01
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant