Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tackle accessibility issues, from WAVE or otherwise #86

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tigt
Copy link
Contributor

@tigt tigt commented Aug 31, 2022

a11y work I did in a fugue state, pushing up so I don't forget

@tigt tigt added the bug label Aug 31, 2022
@github-actions
Copy link

PR Preview Action v1.1.1
🚀 Deployed preview to https://marko-js.github.io/website/./pr-86/
on branch gh-pages at 2022-08-31 14:13 UTC

@tigt
Copy link
Contributor Author

tigt commented Jan 25, 2023

  • Site now only overflows horizontally below 254 pixels wide — a big improvement over the previous 875px on the homepage and 966px on docs pages

    • This has non-obvious accessibility and performance problems, so it’s a good problem to fix: scrolling overflow areas receive assistive tech’s virtual cursor focus, and without an accessible name they just announce something unhelpful. Also, less layout CPU cycles
    • html { overflow-x: hidden } truncated content on the homepage, so it was a no-go.
    • I had to touch the header and footer once the homepage illustrations no longer caused problems, because they also caused overflow
  • Ironically the site now renders a lot better in IE11, despite it not supporting <foreignObject>.

  • I deleted the preventOverscroll() method in <layout-sidebar> and replaced it with CSS’s overscroll-behavior: contain. The JS wasn’t even preventing overscroll for me on Firefox+MacOS+Touchpad, but the CSS does! overscroll-behavior’s browser support is great except for Safari — and on mobile where most of Safari happens, preventing overscroll isn’t really needed since the sidebar overlay takes up the entire viewport.

@tigt
Copy link
Contributor Author

tigt commented Feb 9, 2023

The <foreignObject> change also fixes the huge blank overscroll area on the homepage, as seen here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant